Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add hardhat and foundry check reusable workflows #13

Merged
merged 2 commits into from
Jan 17, 2025
Merged

feat: add hardhat and foundry check reusable workflows #13

merged 2 commits into from
Jan 17, 2025

Conversation

antonbaliasnikov
Copy link
Contributor

What ❔

Add hardhat and foundry check reusable workflows.

Why ❔

To cross-test VS our tooling.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.

@antonbaliasnikov antonbaliasnikov force-pushed the aba-add-check-foundry-workflow branch 8 times, most recently from a06724c to e97ffad Compare January 14, 2025 13:13
@antonbaliasnikov antonbaliasnikov marked this pull request as ready for review January 14, 2025 13:17
@antonbaliasnikov antonbaliasnikov force-pushed the aba-add-check-foundry-workflow branch from e97ffad to 1ed66d6 Compare January 14, 2025 13:25
@antonbaliasnikov antonbaliasnikov force-pushed the aba-add-check-foundry-workflow branch from 1ed66d6 to 8a1ea65 Compare January 14, 2025 13:30
@antonbaliasnikov antonbaliasnikov enabled auto-merge (squash) January 15, 2025 11:16
hedgar2017
hedgar2017 approved these changes Jan 15, 2025
View reviewed changes
Copy link

@hedgar2017 hedgar2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit!

.github/workflows/check-foundry.yaml Outdated Show resolved Hide resolved
@antonbaliasnikov antonbaliasnikov merged commit eb51585 into main Jan 17, 2025
1 check passed
@antonbaliasnikov antonbaliasnikov deleted the aba-add-check-foundry-workflow branch January 17, 2025 11:35
antonbaliasnikov added a commit that referenced this pull request Jan 21, 2025
@antonbaliasnikov
feat: add hardhat and foundry check reusable workflows (#13)
2f6564f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedgar2017 hedgar2017 hedgar2017 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonbaliasnikov @hedgar2017